fix: DF-130: Closes a dropdown list when the placeholder line is clicked #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-odonovan @AndyEPhipps Please have a look at this if you can |
AndyEPhipps
reviewed
Nov 27, 2024
There was a problem hiding this comment.
https://giphy.com/gifs/GitHub-ok-thumbs-up-thumb-NytMLKyiaIh6VH9SPm
as if Github can't embed imgs..
AndyEPhipps
approved these changes
Nov 27, 2024
curlyfriesplease
deleted the
DF-130-close-textinput-on-dropdowninstruction-click
branch
|
🎉 This PR is included in version 8.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Bug DF-130 highlights that we have lost previous functionality, where dropdown lists (such as in the postcode lookup) should close results if you click the first descriptive placeholder line that appears at the top of the results, such as 'Please select a school'
Why is this required?
Keep app behaviour consistent.
link to Jira ticket:
DF-130
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...