fix: DF-148 schools lookup refactor #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or close on click outside
AndyEPhipps
approved these changes
Nov 22, 2024
src/components/Atoms/TextInputWithDropdown/TextInputWithDropdown.js
Outdated
Show resolved
Hide resolved
src/components/Atoms/TextInputWithDropdown/TextInputWithDropdown.js
Outdated
Show resolved
Hide resolved
src/components/Atoms/TextInputWithDropdown/TextInputWithDropdown.js
Outdated
Show resolved
Hide resolved
…ments, reintroduction of accidentally removed comment
AndyEPhipps
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Titles
To pass testing pipeline, these need to follow Conventional Commits spec:
https://www.conventionalcommits.org/en/v1.0.0/
e.g.
feat: create NewForm componentor
fix: update broken link in NewForm componentPR description
What is it doing?
There's a fixed black border around the schoolsLookup compo, and no close-on-click-outside behaviour. This fixes both.
Why is this required?
The donate FE rebuild doesn't need the border, and needs close on click outside.
link to Jira ticket:
DF-148