Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create postcode lookup component in Component Library #590

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

michael-odonovan
Copy link
Contributor

@michael-odonovan michael-odonovan commented Oct 2, 2023

PR description

What is it doing?

Creates new postcode lookup component in our Component Library that can be used in forms that need a postcode lookup.

Why is this required?

DRY, building up on Component Library.

link to Jira ticket:

https://comicrelief.atlassian.net/browse/ENG-2665

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@michael-odonovan michael-odonovan self-assigned this Oct 2, 2023
@michael-odonovan michael-odonovan force-pushed the 2750_create_postcode_lookup_in_CL branch from b7c1eb9 to cd1f930 Compare May 9, 2024 09:37
@AndyEPhipps
Copy link
Contributor

AndyEPhipps commented May 9, 2024

Looking good, man! If we could just stop this button from drifting into the void on larger screens, I think we'll be good:

Screenshot 2024-05-09 at 11 40 29

Just want to zoom out for a second though; are we thinking about this existing as a 'drop-in' to be used to populate already existing address fields within the parent form itself.. rather than it working like the Storybook equivalent?

@michael-odonovan michael-odonovan force-pushed the 2750_create_postcode_lookup_in_CL branch from 14bceb6 to 06dd6af Compare May 9, 2024 13:01
@michael-odonovan
Copy link
Contributor Author

@AndyEPhipps Not sure what you mean about the drop in usage, I think the existing storybook one is dropped into the current contact-us repo:
https://github.com/comicrelief/contact-us/blob/master/src/components/Giro/Giro.js
This would be used similarly. Probably not understanding what you are getting at sorry.

@AndyEPhipps
Copy link
Contributor

@AndyEPhipps Not sure what you mean about the drop in usage, I think the existing storybook one is dropped into the current contact-us repo: https://github.com/comicrelief/contact-us/blob/master/src/components/Giro/Giro.js This would be used similarly. Probably not understanding what you are getting at sorry.

So I really meant the fact that this Lookup component doesn't include any address fields itself; it just uses the Lookup API, then spits out a string made up of each part of the address.

How would you integrate this component within a real form?

Copy link
Contributor

@AndyEPhipps AndyEPhipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw jeez, dude, I feel like I wasn't being clear enough; I was really just asking a legit question as to what was the plan of action, it wasn't a rhetorical one implying "we should have address fields".

That said, this all looks nice, if we could just have functional parity with the OG one here; ('enter manually' button, show/hiding the fields, props to set button and error copy), we'll be onto a winner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants