Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade packages 3a - apps with breaking changes #571

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

refactor: upgrade packages 3a - apps with breaking changes #571

wants to merge 52 commits into from

Conversation

michael-odonovan
Copy link
Contributor

@michael-odonovan michael-odonovan commented May 26, 2023 •
edited
Loading

PR description

What is it doing?

upgrade packages with breaking changes ie. 1.4.2 => 2.1.0

Why is this required?

BAU

link to Jira ticket:

https://comicrelief.atlassian.net/browse/ENG-2543

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@michael-odonovan
update ejs package
c3ee9cb
@michael-odonovan
update moment package
32ed0c4
@michael-odonovan
update react-responsive package
9292083
@michael-odonovan
update react-uid package
3b16ed4
@michael-odonovan
update @babel/cli package
c29fa61
@michael-odonovan
update youtube-player package
ca33612
@michael-odonovan
update react-modal package
f8df23c
@michael-odonovan
update react-currency-format package
47bcb19
@michael-odonovan
update react-canvas-confetti package
d7cbdf2
@michael-odonovan
update prop-types package
2aa03d0
@michael-odonovan
update prettier package
1d58674
@michael-odonovan
update jest-styled-components package
b9bce0e
@michael-odonovan
update eslint-plugin-import package
9f90c53
@michael-odonovan
update eslint-plugin-jsx-a11y package
52021a6
@michael-odonovan
update eslint-plugin-react package
d71324c
@michael-odonovan
update eslint-plugin-react-hooks package
ebd713d
@michael-odonovan
snapshots
a7772b1
@michael-odonovan
jest console errors, fix otherAmountValue undefined
593de84
@michael-odonovan
add otherAmountValue default prop
645da5c
@michael-odonovan
fix lint errors, Input.js label, any => string
1cbed9a
@michael-odonovan
fix lint errors, errormsg is not an attribute of vanilla input tag
c6b4391
@michael-odonovan
snaps
a90175b
@michael-odonovan
fix lint errors, MarketingPreferencesDS missing proptypes for children
0efd4f8
@michael-odonovan
fix lint errors, MarketingPreferencesDS, add disabled propType
25cfe33
@michael-odonovan
remove unused depcheck, ejs package crept back in
a6594aa
@michael-odonovan
fix: remove unused and failing value prop
000e664
@michael-odonovan
Empty commit to trigger build
a7a8398
@michael-odonovan
Merge branch 'master' of https://github.com/comicrelief/component-lib…
a0e42fe 
…rary into yarn_upgrade_cl_packages_2_2523
@michael-odonovan
fix: remove unused husky package that has crept back in
cdeb1f6
@michael-odonovan
refactor: upgrade packages that have updates even while upgrading
35dcfb6
@michael-odonovan michael-odonovan self-assigned this May 26, 2023
@michael-odonovan
Copy link
Contributor Author

michael-odonovan commented Jun 5, 2023 •
edited
Loading

Some notes:

  • have used /* eslint-disable camelcase */ at the top of _MarketingPreferencesDS.js, as after upgrading eslint it throws a lot of errors around the mp_permissionEmail style naming because it wants camelCase naming. I have tried digging them out, however this creates a web of errors, so hopefully disabling one eslint rule for this file is a pragmatic solution? The mp_ is actually pretty handy here for clarity.

@michael-odonovan michael-odonovan force-pushed the upgrade_packages_3_a branch 2 times, most recently from 9ff1ea3 to 9f56231 Compare June 5, 2023 15:18
@michael-odonovan michael-odonovan force-pushed the upgrade_packages_3_a branch 3 times, most recently from aff4ce6 to 0611510 Compare June 8, 2023 15:49
@michael-odonovan
Copy link
Contributor Author

michael-odonovan commented Sep 6, 2023 •
edited
Loading

Putting a maker in the sand this commit, with notes on the state of play:
d1fe44f

The good:

  • React, Styleguidist and Jest have been updated.

The bad:

  • fails jest tests, picture of error below...

The ugly:

  • Have spent a long time trying to sort this issue.
  • Spent an afternoon looking at it with Paul.
  • Have posted this error on Styleguidist repo, without reply from maintainer.

Screenshot 2023-09-06 at 13 58 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michael-odonovan michael-odonovan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-odonovan