307 remove usage of deprecated set-output command for GitHub Actions #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwilbrink
approved these changes
Feb 6, 2023
pascalwilbrink
requested changes
Feb 6, 2023
| -Dsonar.projectKey=com-pas_compas-scl-data-service \ | ||
| -Dsonar.organization=com-pas )" | ||
| -Dsonar.organization=com-pas \" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Thanks for your pr 👍
There's a " missing/leftover
-Dsonar.organization=com-pas >> $GITHUB_OUTPUT
Can we help you to fix this?
There was a problem hiding this comment.
You can absolutely modify my Pull Requests when you want if you are a maintainer (I allowed edits to maintainers) or pick my work and start a new branch and PR if not.
apupier
force-pushed
the
307-removeUsageOfDeprecatedSetOuput
branch
2 times, most recently
from
b4771b9
to
4ed564c
Compare
part of com-pas#307 Signed-off-by: Aurélien Pupier <[email protected]>
Completely removing the intermediate step calculating the tag_name as GitHub Actions is now providing this value in the context directly. See https://github.com/orgs/community/discussions/26686 and https://docs.github.com/en/actions/learn-github-actions/contexts#github-context part of com-pas#307 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
307-removeUsageOfDeprecatedSetOuput
branch
from
4ed564c
to
992a57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #307