Make bootstrap scripts more flexible with //| mill-version key
#5354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
reviewed
Jun 22, 2025
| import utest.framework.TestPath | ||
| import utest.* | ||
|
|
||
| object MillVersionFrontmatterTests extends TestSuite { |
There was a problem hiding this comment.
Let's test this using MILL_TEST_DRY_RUN_LAUNCHER_SCRIPT=true. That would make the tests run much faster than actually running Mill and bootstrapping a Mill daemon which is what the code does now, while still exercising the important part of the code which is the mill.bat/mill.sh parser logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes these limitations from the
//| mill-version: valuefrontmatter://| mill-versionon any line of the build headermill-versionandvalueto be quoted by single or double quotes//| mill-version: 1.0.0-RC2 # this is a commentIt currently allows nonsensical quoting like
//| "mill-version': "1.0.0', but I figured it's not worth complicating the parser, given that it's written in sh/cmd scripts.Fixes #5309