Fixes to Construction Year fields #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set minimum value of construction length to be 1 year, requested by Polly. - Set the maximum and minimum values on the two fields, so you can't enter a start year greater than the end year - or end year smaller than the start year - when using the arrows to change the year.
Polly asked that the "year construction started" be the former "year of construction", and the "year construction ended" should be an entirely new field. (We're ignoring the earliest and latest possible start date fields for now) Part of: colouring-cities#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After workshopping previous changes with Polly:
Includes typo fix for "historial period".