Fix change of vritual attribute can not be tracked. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
requested changes
Jun 3, 2017
| @@ -180,6 +180,12 @@ def non_column_attr=(val) | |||
| expect(@user.audits.last.audited_changes).to eq({ 'name' => ['Brandon', 'Changed'] }) | |||
| end | |||
|
|
|||
| it "should store the change of the custom attribute which extended dirty feature" do | |||
| @user = Models::ActiveRecord::UserDelegateCompany.create(name: 'Brandon', username: 'brandon', password: 'password') | |||
There was a problem hiding this comment.
Use two spaces, not tabs please.
spec/support/active_record/models.rb
Outdated
| end | ||
|
|
||
| # mock activerecord dirty feature | ||
| def company_list_changed? |
spec/support/active_record/models.rb
Outdated
| @@ -64,6 +110,7 @@ class Company < ::ActiveRecord::Base | |||
| class Company::STICompany < Company | |||
| end | |||
|
|
|||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gems like "acts-as-taggable-on" may add some vritual attribute/method that inherits activerecord dirty feature. Please see the follow links:
https://github.com/mbleigh/acts-as-taggable-on/blob/64ed839a8a6021c719fbff9c6bdf74a4fcd65f18/lib/acts_as_taggable_on/taggable/core.rb#L193
https://github.com/mbleigh/acts-as-taggable-on/blob/8e64c3d4a81cfbb8af621228eae36a65c1f94501/lib/acts_as_taggable_on/taggable/dirty.rb#L14
audited_changes uses rails "[]" method to fetch the new value of changed attribute which leads those gems that didn't extend this method to return nil (please see the test example added).
so I change the method to public_send to solve this problem.