Single Table Inherited audits #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
requested changes
Mar 27, 2017
| Synario: | ||
| ```ruby | ||
| class Patient < ActiveRecord::Base | ||
| has_many :diseases |
There was a problem hiding this comment.
Nitpick, indentation should be two spaces (here and below).
| @@ -265,6 +265,35 @@ class User < ActiveRecord::Base | |||
| attr_protected :logins, :audit_ids | |||
| end | |||
| ``` | |||
| ### Single Table Inherited(STI) table audits | |||
|
|
|||
| If you're making audits for a STI record ,then you'll have to change your steps to identify the record's model.You wouldn't be able to retrieve `auditable_type` for the child table record associated audits as it always give parent table class name. | |||
There was a problem hiding this comment.
Missing space before "You wouldn't"
|
|
||
| If you're making audits for a STI record ,then you'll have to change your steps to identify the record's model.You wouldn't be able to retrieve `auditable_type` for the child table record associated audits as it always give parent table class name. | ||
|
|
||
| Synario: |
| ```ruby | ||
| Patient.last.associated_audits.last.auditable.class.name | ||
| ``` | ||
| Actually, in Single table inheritance (STI) each record will have a unique id so you can identify the record using the record id from the parent class as |
There was a problem hiding this comment.
I think here would be a good place to note that this only works if the audited record still exists (auditable may be nil).
|
This PR has been open for over a year now with no activity. @jaswinder97 , do you think it's still needed and would you be interested in returning to this or should we close it? |
|
I'll try to complete it by this weekend.
On 21 Feb 2018 5:39 p.m., "Tomer Brisker" <[email protected]> wrote:
This PR has been open for over a year now with no activity. @jaswinder97
<https://github.com/jaswinder97> , do you think it's still needed and would
you be interested in returning to this or should we close it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARHmIXJkzsUJEryfEveih4AmCkssy6REks5tXAdsgaJpZM4H6oYt>
.
|
|
Ping @jaswinder97 ? do you think you'll get to this? |
|
Hi Tomer,
Yeah I have completed the changes few days back.Will push them by tomorrow
morning
…On 1 Apr 2018 7:35 p.m., "Tomer Brisker" ***@***.***> wrote:
Ping @jaswinder97 <https://github.com/jaswinder97> ? do you think you'll
get to this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARHmIfzEa8Q6hjkLfBtXUqAFKaI2cl0xks5tkN6cgaJpZM4H6oYt>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single Table Inheritance will always store parent class name as auditable_type name instead of child class name but we can retrieve the actual child class name by first retrieving the auditable record and then identify its class name.