Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load code for exporting/importing comments conditionally. #249

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

mauritsvanrees
Copy link
Member

plone.app.discussion is optional since Plone 6.1.

`plone.app.discussion` is optional since Plone 6.1.
@mauritsvanrees mauritsvanrees requested a review from pbauer January 7, 2025 13:57
@mauritsvanrees
Copy link
Member Author

This PR is best checked ignoring white space changes:
https://github.com/collective/collective.exportimport/pull/249/files?w=1

Latest 6.0.14 no longer officially supports Python 3.8.
It really does not work anymore either, unless we would add an extra version pin:
Pillow 11 is pinned, and this does not work on Python 3.8.
See GHA failure here: https://github.com/collective/collective.exportimport/actions/runs/12652930616/job/35256797334?pr=249
@pbauer pbauer merged commit bcb7f7f into main Jan 7, 2025
10 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-pad-optional branch January 7, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants