-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.16.0 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for non-checksummed address
chore: added USDC gasless transfer e2e test
Milan/v0.16.0 release prep
✅ Heimdall Review Status
|
milan-cb
requested review from
rohan-agarwal-coinbase,
alex-stone and
jazz-cb
January 28, 2025 22:41
jazz-cb
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
A bug fix for non-checksummed addresses and an additional E2E for gasless transfers were added in this release. The change was made to prevent users from encountering an "unsupported asset" error when using non-checksummed addresses for assets.
The E2E gasless transfers was added to cover the entire flow of sending USDC using the gasless transfer option. Note: this test has been skipped due to unpredictable latency on gasless transfers.
Qualified Impact
This component mainly affects the assets class, where the asset id gets normalized. If there are any issues, it should be safe to revert back to v0.15.0 and then fix any errors before re-releasing.