chore: added USDC gasless transfer e2e test #369
Merged
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-cb
requested review from
alex-stone,
jazz-cb and
rohan-agarwal-coinbase
jazz-cb
reviewed
Jan 28, 2025
src/tests/e2e.ts
Outdated
|
|
||
| console.log("Making gasless transfer of 0.000001 USDC..."); | ||
| const transfer = await sourceWallet.createTransfer({ | ||
| amount: 0.000001, |
There was a problem hiding this comment.
could create a constant for transferAmount and reuse it here and line 187
There was a problem hiding this comment.
Agreed, I'll go ahead and update. Thanks!
jazz-cb
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
A Gasless transfer test was added for E2E tests. This test improves coverage for the gasless transfer feature, by ensuring the SDK can make gasless transfers for USDC over Base Sepolia.
Qualified Impact
This change will impact the E2E tests, which currently run in our CI/CD pipeline for Github PRs. The wallet data that is used for transferring USDC over Base Sepolia will need to be funded in case in runs out of funds for the test to pass.