feat: Add support for deploying arbitrary contracts #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
rohan-agarwal-coinbase
force-pushed
the
rohan/PSDK-797
branch
from
1276f6a to
be5056c
Compare
rohan-agarwal-coinbase
changed the title
rohan-agarwal-coinbase
requested review from
John-peterson-coinbase,
0xRAG and
jazz-cb
0xRAG
reviewed
Jan 17, 2025
!
0xRAG
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
deployContractin walletAddress.ts and wallet.ts to support deploying an arbitrary contract using the compiler version, solidity input json, contract name of the class to be deployed, and constructor argumentsNote to reviewers
Some files were updated for linting reasons, and were otherwise unrelated to this PR
Testing
Unit tests added, and ran e2e tests successfully
Qualified Impact