Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] fetch historical balance #147

Merged
merged 20 commits into from
Aug 12, 2024
Merged

[Balance] fetch historical balance #147

merged 20 commits into from
Aug 12, 2024

Conversation

xinyu-li-cb
Copy link
Contributor

  • init
  • update tests with usd_value
  • tests
  • api.ts updates
  • fix test
  • update change log
  • [Balance] fetch historical balance
  • formatting
  • fix lint
  • add max size for fetching all history
  • rebase error
  • tweak naming
  • address comments
  • move list historical balance test under address
  • address comment
  • fix lint
  • fix IDE change
  • update changelog
  • [PSDK-361] Gasless Sends Support ([PSDK-361] Gasless Sends Support #142)
  • add struct for ListHistoricalBalancesOptions

What changed? Why?

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 12, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@xinyu-li-cb xinyu-li-cb changed the base branch from master to v0.0.16 August 12, 2024 19:43
@xinyu-li-cb xinyu-li-cb marked this pull request as ready for review August 12, 2024 19:45
@xinyu-li-cb xinyu-li-cb changed the title historicalbalance [Balance] fetch historical balance Aug 12, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/coinbase/historical_balance.ts Outdated Show resolved Hide resolved
src/tests/historical_balance_test.ts Outdated Show resolved Hide resolved
src/tests/historical_balance_test.ts Outdated Show resolved Hide resolved
@xinyu-li-cb xinyu-li-cb merged commit e38d836 into v0.0.16 Aug 12, 2024
4 checks passed
John-peterson-coinbase added a commit that referenced this pull request Aug 14, 2024
* [chore] Update package-lock.json (#132)

* [Balance] fetch historical balance

* formatting

* fix lint

* add max size for fetching all history

* rebase error

* tweak naming

* address comments

* move list historical balance test under address

* address comment

* fix lint

* fix IDE change

* update changelog

* add struct for ListHistoricalBalancesOptions

* fix format

* fix lint

* change log version

* address comments

---------

Co-authored-by: John Peterson <[email protected]>
John-peterson-coinbase added a commit that referenced this pull request Aug 14, 2024
* initial commit for list balances

* fix tests

* rm unnecessary change

* return from model

* lint

* fix typo

* rename some vars and update tests

* rename func

* rm unnecessary var

* lint

* fix lint and test

* rm request body

* rm request totally and update desc

* clean up

* add to export

* fix

* fix test

* add test

* add list historical staking balance to address

* add tests in address

* clean up a bit

* init

* update tests with usd_value

* tests

* fix test

* [PSDK-361] Gasless Sends Support (#142)

* [PSDK-361] Gasless Sends Support

* stone's comments

* readme + changelog

* leave unrelated unchanged

* force

* rename some test vars

* [Balance] fetch historical balance (#147)

* [chore] Update package-lock.json (#132)

* [Balance] fetch historical balance

* formatting

* fix lint

* add max size for fetching all history

* rebase error

* tweak naming

* address comments

* move list historical balance test under address

* address comment

* fix lint

* fix IDE change

* update changelog

* add struct for ListHistoricalBalancesOptions

* fix format

* fix lint

* change log version

* address comments

---------

Co-authored-by: John Peterson <[email protected]>

* change prefix of static method test

* changelog, package.json version bump + docs

* generate api client + fix unit tests (feature_set model type issue)

* ethereum-mainnet + polygon-mainnet changelog entry

---------

Co-authored-by: marc.xu <[email protected]>
Co-authored-by: Shreif Abdallah <[email protected]>
Co-authored-by: xinyu-li-cb <[email protected]>
@xinyu-li-cb xinyu-li-cb deleted the historicalbalance branch August 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants