-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Balance] fetch historical balance #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dejs into historicalbalance
🟡 Heimdall Review Status
|
John-peterson-coinbase
approved these changes
Aug 12, 2024
John-peterson-coinbase
added a commit
that referenced
this pull request
Aug 14, 2024
* [chore] Update package-lock.json (#132) * [Balance] fetch historical balance * formatting * fix lint * add max size for fetching all history * rebase error * tweak naming * address comments * move list historical balance test under address * address comment * fix lint * fix IDE change * update changelog * add struct for ListHistoricalBalancesOptions * fix format * fix lint * change log version * address comments --------- Co-authored-by: John Peterson <[email protected]>
John-peterson-coinbase
added a commit
that referenced
this pull request
Aug 14, 2024
* initial commit for list balances * fix tests * rm unnecessary change * return from model * lint * fix typo * rename some vars and update tests * rename func * rm unnecessary var * lint * fix lint and test * rm request body * rm request totally and update desc * clean up * add to export * fix * fix test * add test * add list historical staking balance to address * add tests in address * clean up a bit * init * update tests with usd_value * tests * fix test * [PSDK-361] Gasless Sends Support (#142) * [PSDK-361] Gasless Sends Support * stone's comments * readme + changelog * leave unrelated unchanged * force * rename some test vars * [Balance] fetch historical balance (#147) * [chore] Update package-lock.json (#132) * [Balance] fetch historical balance * formatting * fix lint * add max size for fetching all history * rebase error * tweak naming * address comments * move list historical balance test under address * address comment * fix lint * fix IDE change * update changelog * add struct for ListHistoricalBalancesOptions * fix format * fix lint * change log version * address comments --------- Co-authored-by: John Peterson <[email protected]> * change prefix of static method test * changelog, package.json version bump + docs * generate api client + fix unit tests (feature_set model type issue) * ethereum-mainnet + polygon-mainnet changelog entry --------- Co-authored-by: marc.xu <[email protected]> Co-authored-by: Shreif Abdallah <[email protected]> Co-authored-by: xinyu-li-cb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact