Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Wallet.import Must Load List of Addresses during Hydration #145

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[hotfix] Wallet.import Must Load List of Addresses during Hydration #145

merged 1 commit into from
Aug 12, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Resolves A wallet hydration problem #144
  • Wallet hydration was silently failing due to Wallet.import not rehydrating the list of addresses for the wallet
  • This adds the addresses fetch to Wallet.import

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 12, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase merged commit 7bba82c into master Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

@alex-stone alex-stone alex-stone approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A wallet hydration problem
4 participants
@John-peterson-coinbase @cb-heimdall @alex-stone @jazz-cb