Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC20 approve and allowance functionality #289

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add ERC20 approve and allowance functionality #289

wants to merge 18 commits into from

Conversation

0xgeorgemathew
Copy link

Add ERC20 approve and allowance functionality

Adds two new methods to the ERC20 action provider:

  1. approve(): Enables token approval for spenders
  2. getAllowance(): Checks spender allowances

Changes

  • TypeScript implementation with error handling
  • Corresponding zod schemas
  • Documentation for both methods

Review Focus

  • Error handling robustness
  • Schema validation completeness
  • Transaction wait for approval confirmation
  • Documentation clarity

This enhances token management by supporting delegation of spending rights.

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase
Copy link
Contributor

@0xgeorgemathew - Please add tests and chatbot chat snippets of the actions being used with the example agent to the PR description. Otherwise LGTM 🚀

@John-peterson-coinbase John-peterson-coinbase added action New action implemented on existing action provider triaged changes requested PR / Issue has changes requested cherry labels Feb 10, 2025
@0xRAG 0xRAG removed the triaged label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
action New action implemented on existing action provider changes requested PR / Issue has changes requested cherry
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xgeorgemathew @cb-heimdall @John-peterson-coinbase @0xRAG