Skip to content

[prep CDF-24982] 🚅 Implemented fast delete #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jun 28, 2025

Description

This is a reimplementation of the client.data_modeling.instances.delete(...) method from the cognite-sdk overcoming the following issues

  1. The cognite-sdk method is limited to 1 worker, even though the API support 2. This will be used in the purge command that potentially deletes million of nodes, which is likely to happen during the migration.
  2. Standardized the signature of the function to simply take instance IDs instead of distinguishing between nodes and edges. I need this in the Canvas wrapper, and expect this to be useful for other cases as well.

Changelog

  • Patch
  • Minor
  • Skip

Copy link

github-actions bot commented Jun 28, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19949 15647 78% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/client/_constants.py 100% 🟢
cognite_toolkit/_cdf_tk/client/api/extended_data_modeling.py 88% 🟢
cognite_toolkit/_cdf_tk/client/utils/_concurrency.py 92% 🟢
TOTAL 93% 🟢

updated for commit: cd6fa10 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant