[CDF-25127] 🐛Relative path in cdf modules pull #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Jun 27, 2025
| @@ -96,7 +96,7 @@ def get_resources( | |||
| resources = ( | |||
| resource | |||
| for resource in resources | |||
| if (resource.source.path == selected or resource.source.path.is_relative_to(selected)) | |||
| if (resource.source.path == selected or resource.source.path.is_relative_to(selected.absolute())) | |||
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context In Toolkit, we have a command
cdf modules pullthat allows you to 'pull' configuration from CDF down to local configurations. For example, I have a transformations which I have changed in the fusion UI, and I want to update the SQL from the transformation. I can do this with the commandcdf modules pull modules/my_module/transformations/my_local_config.Transformation.yaml.Giving a relative path would skip the selection of the resources and it would not be pulled.
Changelog
cdf
Fixed
cdf module pull <path>no longer skips resources when the given path is relative.templates
No changes.