[CDF-24799] Pydantic validation for views #1672
Open
+577
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
doctrino
reviewed
Jun 25, 2025
| ) | ||
| filter: dict[str, Any] | None = Field( | ||
| default=None, | ||
| description="A filter Domain Specific Language (DSL) used to create advanced filter queries.", |
There was a problem hiding this comment.
This is not correct, the filter for on a view is used to determine which instances are returned by the view.
| description="Description of the content and suggested use for this property..", | ||
| max_length=1024, | ||
| ) | ||
| source: ViewReference | None = Field( |
There was a problem hiding this comment.
The description is incorrect. Suggest we only keep it on the derived classes. It is optional on the Container properties, while it is required for edges and reverse direct relations
| return serialized_data | ||
|
|
||
|
|
||
| class CreateViewProperty(ViewProperty): |
There was a problem hiding this comment.
Lets call this ContainerViewProperty alternatively, MappedViewProperty
doctrino
added
the
waiting-for-risk-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces pydantic validation model for View Resource class that matches the YAML file format that toolkit expects.
Changelog