Skip to content

[CDF-25070] ⛓️‍💥 Unlink timeseries #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jun 23, 2025

Description

This implements the unlink endpoint for timeseries. Currently, this is only deployed in a dev cluster. The unlink endpoint enables you to unlink CogniteTimeSeries from an asset centric timeseries. This is useful in the case when you want to delete the CogniteTimeSeries nodes, but not lose the datapoints stored.

The expected way this will be used

  1. Unlink asset-centric timeseries from CogniteTimeSeries.
  2. Delete CogniteTimeSeries.
  3. Set pending instance ID on the asset-centric timeseries.
  4. Create new CogniteTimeSeries.

This is necessary if you want the asset-centric timeseries to be linked to a different node than what is currently linked to.

Changelog

  • Patch
  • Minor
  • Skip

Copy link

github-actions bot commented Jun 23, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19874 15561 78% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/client/api/extended_timeseries.py 61% 🟢
TOTAL 61% 🟢

updated for commit: 9dad394 by action🐍

muradsater
muradsater previously approved these changes Jun 23, 2025
@doctrino doctrino added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jun 23, 2025
@doctrino doctrino enabled auto-merge (squash) June 27, 2025 09:11
@doctrino doctrino added waiting-for-risk-review Waiting for a member of the risk review team to take an action and removed waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Jun 27, 2025
@@ -76,3 +82,46 @@ def test_set_pending_instance_id(self, dev_cluster_client: ToolkitClient) -> Non
if created_dm is not None:
# This will delete the CogniteTimeSeries and the asset-centric time series
client.data_modeling.instances.delete(cognite_ts.as_id())

def test_unlink_instance_ids(self, dev_cluster_client: ToolkitClient, space: str) -> None:
Copy link

@larshagencognite larshagencognite Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only testing 1 out of 7 type combinations for unlink_instance_ids

(None,None),
(int, str)
(None,str)
(int,None)
(list[int],None)
(None,list[str])
(list[int],list[str])

@doctrino doctrino removed the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk-review-ongoing Risk review is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants