-
Notifications
You must be signed in to change notification settings - Fork 5
[CDF-25070] ⛓️💥 Unlink timeseries #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doctrino
wants to merge
7
commits into
main
Choose a base branch
from
unlink-timeseries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+132
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
muradsater
previously approved these changes
Jun 23, 2025
@@ -76,3 +82,46 @@ def test_set_pending_instance_id(self, dev_cluster_client: ToolkitClient) -> Non | |||
if created_dm is not None: | |||
# This will delete the CogniteTimeSeries and the asset-centric time series | |||
client.data_modeling.instances.delete(cognite_ts.as_id()) | |||
|
|||
def test_unlink_instance_ids(self, dev_cluster_client: ToolkitClient, space: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only testing 1 out of 7 type combinations for unlink_instance_ids
(None,None),
(int, str)
(None,str)
(int,None)
(list[int],None)
(None,list[str])
(list[int],list[str])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the unlink endpoint for timeseries. Currently, this is only deployed in a dev cluster. The unlink endpoint enables you to unlink CogniteTimeSeries from an asset centric timeseries. This is useful in the case when you want to delete the CogniteTimeSeries nodes, but not lose the datapoints stored.
The expected way this will be used
This is necessary if you want the asset-centric timeseries to be linked to a different node than what is currently linked to.
Changelog