Skip to content

Commit

Permalink
content/code-review: Minor updates
Browse files Browse the repository at this point in the history
  • Loading branch information
rkdarst committed Mar 13, 2024
1 parent e2f4741 commit 8484b3e
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions content/code-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,25 @@ previous episode.
deliberately introduce a typo and also a larger mistake which we will want to fix during the code review.
1. Open a pull request towards the main branch.
1. As a reviewer to somebody else's pull request, ask for an improvement and
also directly suggest a change for the small typo.
1. As the submitter, learn how to accept the suggested change.
also directly suggest a change for the small typo. (Hint:
suggestions are possible through the GitHub web interface, view of
a pull request, "Files changed" view, after selecting some lines.
Look for the "±" button.)
1. As the submitter, learn how to accept the suggested change. (Hint:
GitHub web interface, "Files Changed" view.)
1. As the submitter, improve the pull request without having to close and open
a new one: by adding a new commit to the same branch.
a new one: by adding a new commit to the same branch. (Hint: push
to the branch again.)
1. Once the changes are addressed, merge the pull request.
:::


## Help and discussion

From here on out, we don't give detailed steps to the solution. You
need to combine what you know, and the extra info below, in order to
solve the above.

### How to ask for changes in a pull request

Technically, there are at least two common ways to ask for changes in a pull
Expand Down

0 comments on commit 8484b3e

Please sign in to comment.