Skip to content

chore: simplify prettier config #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

chore: simplify prettier config #528

merged 2 commits into from
Jun 5, 2025

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jun 3, 2025

Pretty much all of the settings in the prettier config here are either in conflict with coder/coder, or are just the defaults now. We can just remove the whole file to get closer to matching coder/coder.

@aslilac
Copy link
Member Author

aslilac commented Jun 3, 2025

I would also like to switch this repository to tabs, but that will be a much bigger diff.

I decided I might as well make the diff bigger. Go big or go home.

@matifali
Copy link
Member

matifali commented Jun 4, 2025

We don't use prettier in coder/coder anymore. Maybe move to biome here too.

@aslilac
Copy link
Member Author

aslilac commented Jun 5, 2025

I think the editor integration for prettier is pretty universally better. in a smaller repo like this where it's fast enough I actually think it's better to stick with prettier.

@aslilac aslilac reopened this Jun 5, 2025
@aslilac aslilac requested review from matifali and bcpeinhardt June 5, 2025 17:55
@aslilac aslilac merged commit f785902 into main Jun 5, 2025
2 of 4 checks passed
@aslilac aslilac deleted the lilac/fmt branch June 5, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants