feature: ssh access to git repository #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build-in (or mount) private key in envbuilder image for access repository
matifali
requested review from
kylecarbs and
aaronlehmann
and removed request for
kylecarbs
Co-authored-by: Aaron Lehmann <[email protected]>
Parse first layer of path to find valid private key.
ast9501
commented
Apr 27, 2024
ggjulio
reviewed
Jun 28, 2024
| @@ -147,6 +148,41 @@ resource "docker_container" "dev" { | |||
| } | |||
| ``` | |||
|
|
|||
| ### PrivateKey-based authentication | |||
| * Prebuild private key in your envbuilder image | |||
There was a problem hiding this comment.
Isn't this dangerous if we use a cache registry ?
The layer containing the private key may end up in the registry, or am I missing something ?
There was a problem hiding this comment.
My original assumption was that this image may be stored in a private registry, so I didn't take into consideration the potential issue of having a private key in the image layers.
|
Is there any other way as of right now to clone a private repository? |
Maybe you can reference to README doc, there are some guides to access to different kind of git (also for private repository): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using private key to access repositories.