Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context API integration #61

Open
JMStudiosJoe opened this issue Apr 3, 2018 · 10 comments
Open

Context API integration #61

JMStudiosJoe opened this issue Apr 3, 2018 · 10 comments

Comments

@JMStudiosJoe
Copy link
Collaborator

No description provided.

@JMStudiosJoe
Copy link
Collaborator Author

maybe not yet but reviewing this blog https://www.valentinog.com/blog/react-redux-tutorial-beginners/

@thedocbwarren
Copy link
Contributor

@JMStudiosJoe
Copy link
Collaborator Author

Ah I heard about this yes will look into it. But for now need to determine if we need it yet or not and I’m think long we don’t need it yet. What are your thoughts @thedocbwarren ?

Sent with GitHawk

@thedocbwarren
Copy link
Contributor

I don’t think so yetbas there aren’t a lot of components. Context and and some cool patterns can help keep things neat and don’t require redux or difficult property passing.

@JMStudiosJoe
Copy link
Collaborator Author

closing issue since not needed yet

@JMStudiosJoe
Copy link
Collaborator Author

ok so think i have hit the mark where I need redux or something. When viewing a report and user wants to edit it from the modal which is quite a few components deep from MealTallyComponent so is https://reactjs.org/docs/context.html what the cool kids on the block are using these days? @thedocbwarren

@JMStudiosJoe JMStudiosJoe reopened this Apr 17, 2018
@JMStudiosJoe
Copy link
Collaborator Author

I see their example passing a simple string but what about an object or function like editReport which takes a report object then just goes to the MealTallyComponent?

@JMStudiosJoe
Copy link
Collaborator Author

Turns out users will not be editing much and can create a new one to override the one they need to edit but still should think about integrating context or redux.

@JMStudiosJoe
Copy link
Collaborator Author

JMStudiosJoe commented May 24, 2018

context it is https://reactjs.org/docs/context.html

@JMStudiosJoe JMStudiosJoe changed the title Redux integration Context API integration May 24, 2018
@ctram
Copy link
Collaborator

ctram commented Jun 30, 2018

@JMStudiosJoe Hi folks, are you guys accepting contributions for this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants