Issue 105/rotate volunteer images #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycwilliams
requested review from
ogorman89,
xscottxbrownx and
Jared-Krajewski
Jared-Krajewski
requested changes
Feb 18, 2024
Please elaborate. |
The images will need to be inside of a container that limits their size for consistency, with this update, images rotating load to whatever size the image is and in any position. Currently it was just sized by the images but wasn't as big of a deal because they were static and it maintained its styling because of that. We would want to maintain the two square images with a longer middle one. |
|
Unassigning myself from this but leaving open the PR. The branch can be taken over, if anyone wants to take it on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #105
Adds function that shuffles the bottom three images upon page reload. The top two remain static.
Screenshots (if applicable):
video.1.webm
(Shuffling demonstration begins after a few seconds)