Bump botium-core to latest (security alert remediation) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #129.
Botium-core has since lost its dependency on
vm2, which is currently showing as a 'critical' vulnerability in npm audit (and therefore dependabot in our repository at work). This is a minimal change to deal with that alert.I've verified that this project appears to still run successfully in the sample project:
And
npm run buildis fine:Let me know if there's anything else I can do. There are other dependencies which could be updated, but I've kept this minimal to focus on the security issue (even though realistically most botium use cases won't be public-facing).