[FYST-1089] refactor twilio service

app/controllers/twilio_webhooks_controller.rb

@@ -55,6 +55,6 @@ def outbound_call_connect
   private
 
   def validate_twilio_request
-    return head 403 unless TwilioService.valid_request?(request)
+    return head 403 unless TwilioService.new.valid_request?(request)
   end
 end

app/jobs/bulk_action/send_one_bulk_signup_message_job.rb

@@ -3,8 +3,9 @@ class SendOneBulkSignupMessageJob < ApplicationJob
     include Rails.application.routes.url_helpers
 
     def perform(signup, bulk_signup_message)
+      service_info = MultiTenantService.new(signup.class.name == "CtcSignup" ? :ctc : :gyr)
       if bulk_signup_message.message_type == "sms"
-        line_type = TwilioService.get_metadata(phone_number: signup.phone_number)&.dig("type")
+        line_type = TwilioService.new(service_info.service_type).get_metadata(phone_number: signup.phone_number)&.dig("type")
         if line_type == "landline"
           DatadogApi.increment("twilio.outgoing_text_messages.bulk_signup_message_not_sent_landline")
           return
@@ -19,14 +20,13 @@ def perform(signup, bulk_signup_message)
       message_id =
         case bulk_signup_message.message_type
         when "sms"
-          TwilioService.send_text_message(
+          TwilioService.new(service_info.service_type).send_text_message(
             to: signup.phone_number,
             body: bulk_signup_message.message,
             status_callback: twilio_update_status_url(outgoing_message_status.id, locale: nil),
             outgoing_text_message: outgoing_message_status
           )&.sid
         when "email"
-          service_info = MultiTenantService.new(signup.class.name == "CtcSignup" ? :ctc : :gyr)
           SignupFollowupMailer.new.followup(email_address: signup.email_address, message: OpenStruct.new(
             email_body: bulk_signup_message.message,
             service_type: service_info.service_type,

app/jobs/get_phone_metadata_job.rb

@@ -2,7 +2,7 @@ class GetPhoneMetadataJob < ApplicationJob
   def perform(intake)
     return if intake.phone_number.blank?
 
-    metadata = TwilioService.get_metadata(phone_number: intake.phone_number)
+    metadata = TwilioService.new(:ctc).get_metadata(phone_number: intake.phone_number)
 
     return if metadata.blank?
 

app/jobs/request_verification_code_for_login_job.rb

@@ -43,11 +43,11 @@ def perform(email_address: nil, phone_number: nil, locale:, visitor_id:, service
                when :statefile
                  I18n.t("state_file.intake_logins.no_match_sms", url: url, locale: locale)
                end
-        TwilioService.send_text_message(
+        TwilioService.new(service_type).send_text_message(
           to: phone_number,
           body: body
         )
       end
     end
   end
-end
+end

app/jobs/send_outgoing_text_message_job.rb

@@ -4,7 +4,7 @@ class SendOutgoingTextMessageJob < ApplicationJob
   def perform(outgoing_text_message_id)
     outgoing_text_message = OutgoingTextMessage.find(outgoing_text_message_id)
     begin
-      message = TwilioService.send_text_message(
+      message = TwilioService.new.send_text_message( # TODO: set explicit service scope; is this job for :ctc or :gyr?
         to: outgoing_text_message.to_phone_number,
         body: outgoing_text_message.body,
         status_callback: outgoing_text_message_url(outgoing_text_message, locale: nil),

app/lib/ctc_signup_message.rb

@@ -29,7 +29,7 @@ def self.send(count)
       BODY
 
       if ctc_signup.phone_number.present?
-        TwilioService.send_text_message(
+        TwilioService.new(:ctc).send_text_message(
           to: ctc_signup.phone_number,
           body: (body % { name: ctc_signup.name }),
         )
@@ -55,11 +55,12 @@ def self._send_one_launch_announcement(ctc_signup)
     es_sms = '¡Gracias por registrarse para recibir las actualizaciones de GetCTC! ¡GetCTC está oficialemente disponible y a su disposición para presenter su declaración de impuestos de forma simplificada para reclamara su Crédito Tributario por Hijos y los pagos de estímulo! Ingrese a GetCTC.org y haga clic en “Declare de forma simplificada ahora” para iniciar.'
 
     if ctc_signup.phone_number.present?
-      TwilioService.send_text_message(
+      ts = TwilioService.new(:ctc)
+      ts.send_text_message(
         to: ctc_signup.phone_number,
         body: en_sms,
       )
-      TwilioService.send_text_message(
+      ts.send_text_message(
         to: ctc_signup.phone_number,
         body: es_sms,
       )

app/models/signup.rb

@@ -34,7 +34,7 @@ def self.send_message(message_name, batch_size=nil, after: nil)
       end
 
       if signup.phone_number.present?
-        TwilioService.send_text_message(to: signup.phone_number, body: message.sms_body)
+        TwilioService.new(:ctc).send_text_message(to: signup.phone_number, body: message.sms_body)
         signup.touch(sent_at_column)
       end
     end

app/services/multi_tenant_service.rb

@@ -112,6 +112,14 @@ def backtax_years(now = DateTime.now)
     filing_years(now).without(current_tax_year)
   end
 
+  def twilio_creds
+    {
+      account_sid: EnvironmentCredentials.dig(:twilio, :account_sid),
+      auth_token: EnvironmentCredentials.dig(:twilio, :auth_token),
+      messaging_service_id: EnvironmentCredentials.dig(:twilio, :messaging_services, service_type)
+    }
+  end
+
   class << self
     def ctc
       new(:ctc)

app/services/twilio_service.rb

@@ -1,9 +1,10 @@
 class TwilioService
-  FAILED_STATUSES = ["undelivered", "failed", "delivery_unknown", "twilio_error"].freeze
-  SUCCESSFUL_STATUSES = ["sent", "delivered"].freeze
-  IN_PROGRESS_STATUSES = ["accepted", "queued", "sending", nil].freeze
+  FAILED_STATUSES = %w(undelivered failed delivery_unknown twilio_error)
+  SUCCESSFUL_STATUSES = %w(sent delivered)
+  IN_PROGRESS_STATUSES = %w(accepted queued sending) << nil
   ALL_KNOWN_STATUSES = FAILED_STATUSES + SUCCESSFUL_STATUSES + IN_PROGRESS_STATUSES
-  ORDERED_STATUSES = [nil, "twilio_error"] + %w[
+  ORDERED_STATUSES = %w(
+    twilio_error
     queued
     accepted
     sending
@@ -12,104 +13,101 @@ class TwilioService
     delivered
     undelivered
     failed
-  ].freeze
+  ).unshift(nil) # why do we need nil in this list, and why must it be first?
 
-  class << self
-    def valid_request?(request)
-      validator = Twilio::Security::RequestValidator.new(EnvironmentCredentials.dig(:twilio, :auth_token))
-      validator.validate(
-        request.url,
-        request.POST,
-        request.headers["X-Twilio-Signature"],
-      )
-    end
+  attr_reader :client, :messaging_service_sid, :auth_token
 
-    def fetch_attachment(url)
-      begin
-        response = Net::HTTP.get_response(URI(url)) # first we get a redirect from Twilio to S3
-        response = Net::HTTP.get_response(URI(response['location'])) # then we get a redirect from S3 to S3
-        response = Net::HTTP.get_response(URI(response['location'])) # finally we should get a 200 OK with the file
-        filename_from_s3 = response['content-disposition'].split('"').last # S3 gives us the original filename
-        {
-          filename: filename_from_s3,
-          body: response.body,
-        }
-      rescue ArgumentError => e
-        Rails.logger.error("Error getting attachment from Twilio: #{url}: #{response&.code}: #{response&.to_hash}")
-        {
-          filename: "unknown-file",
-          body: nil
-        }
-      end
-    end
+  def initialize(service_type = :gyr)
+    creds = MultiTenantService.new(service_type).twilio_creds
+    @messaging_service_sid = creds[:messaging_service_id]
+    @auth_token = creds[:auth_token]
+    @client = Twilio::REST::Client.new(creds[:account_sid], auth_token)
+  end
 
-    def parse_attachments(params)
-      num_media = params["NumMedia"].to_i
+  def send_text_message(to:, body:, status_callback: nil, outgoing_text_message: nil)
+    arguments = {
+      messaging_service_sid: ENV['MESSAGING_SERVICE_SID'] || messaging_service_sid, # why do we check the environment for this??
+      to: to,
+      body: body
+    }
+    arguments[:status_callback] = status_callback if status_callback.present?
 
-      (0..(num_media - 1)).map do |i|
-        content_type = params["MediaContentType#{i}"]
-        attachment = fetch_attachment(params["MediaUrl#{i}"])
+    DatadogApi.increment("twilio.outgoing_text_messages.sent")
 
-        if FileTypeAllowedValidator.mime_types(Document).include?(content_type) && !attachment[:body].empty?
-          {
-            content_type: params["MediaContentType#{i}"],
-            filename: attachment[:filename],
-            body: attachment[:body]
-          }
-        else
-          {
-            content_type: "text/plain;charset=UTF-8",
-            filename: "invalid-#{attachment[:filename]}.txt",
-            body: <<~TEXT
-              Unusable file with unknown or unsupported file type.
-              File name: #{attachment[:filename]}
-              File type: #{content_type}
-              File size: #{attachment[:body].size} bytes
-            TEXT
-          }
-        end
+    client.messages.create(**arguments)
+  rescue Twilio::REST::RestError => e
+    status_key =
+      if outgoing_text_message.is_a?(OutgoingMessageStatus)
+        :delivery_status
+      else
+        :twilio_status
       end
-    end
+    outgoing_text_message&.update(status_key => "twilio_error")
 
-    def client
-      @@_client ||= Twilio::REST::Client.new(
-        EnvironmentCredentials.dig(:twilio, :account_sid),
-        EnvironmentCredentials.dig(:twilio, :auth_token)
-      )
+    unless e.code == 21211 # Invalid 'To' Phone Number https://www.twilio.com/docs/api/errors/21211
+      raise # should we include the original exception here (e)??
     end
 
-    def send_text_message(to:, body:, status_callback: nil, outgoing_text_message: nil)
-      arguments = {
-        messaging_service_sid: ENV['MESSAGING_SERVICE_SID'] || EnvironmentCredentials.dig(:twilio, :messaging_service_sid),
-        to: to,
-        body: body
-      }
-      arguments[:status_callback] = status_callback if status_callback.present?
+    nil
+  end
 
-      DatadogApi.increment("twilio.outgoing_text_messages.sent")
+  def get_metadata(phone_number:)
+    client.lookups.v2.phone_numbers(phone_number).fetch(fields: 'line_type_intelligence').line_type_intelligence
+  rescue Twilio::REST::RestError
+    {}
+  end
 
-      client.messages.create(**arguments)
-    rescue Twilio::REST::RestError => e
-      status_key =
-        if outgoing_text_message.is_a?(OutgoingMessageStatus)
-          :delivery_status
-        else
-          :twilio_status
-        end
-      outgoing_text_message&.update(status_key => "twilio_error")
+  def valid_request?(request)
+    validator = Twilio::Security::RequestValidator.new(auth_token)
+    validator.validate(
+      request.url,
+      request.POST,
+      request.headers["X-Twilio-Signature"],
+    )
+  end
 
-      unless e.code == 21211 # Invalid 'To' Phone Number https://www.twilio.com/docs/api/errors/21211
-        raise
-      end
+  def fetch_attachment(url)
+    response = Net::HTTP.get_response(URI(url)) # first we get a redirect from Twilio to S3
+    response = Net::HTTP.get_response(URI(response['location'])) # then we get a redirect from S3 to S3
+    response = Net::HTTP.get_response(URI(response['location'])) # finally we should get a 200 OK with the file
+    filename_from_s3 = response['content-disposition'].split('"').last # S3 gives us the original filename
+    {
+      filename: filename_from_s3,
+      body: response.body,
+    }
+  rescue ArgumentError => e
+    Rails.logger.error("Error getting attachment from Twilio: #{url}: #{response&.code}: #{response&.to_hash}")
+    {
+      filename: "unknown-file",
+      body: nil
+    }
+  end
 
-      nil
-    end
+  def parse_attachments(params)
+    num_media = params["NumMedia"].to_i
 
-    def get_metadata(phone_number:)
-      client.lookups.v2.phone_numbers(phone_number).fetch(fields: 'line_type_intelligence').line_type_intelligence
+    (0...num_media).map do |i|
+      content_type = params["MediaContentType#{i}"]
+      attachment = fetch_attachment(params["MediaUrl#{i}"])
 
-    rescue Twilio::REST::RestError
-      {}
+      if FileTypeAllowedValidator.mime_types(Document).include?(content_type) && !attachment[:body].empty?
+        {
+          content_type: params["MediaContentType#{i}"],
+          filename: attachment[:filename],
+          body: attachment[:body]
+        }
+      else
+        {
+          content_type: "text/plain;charset=UTF-8",
+          filename: "invalid-#{attachment[:filename]}.txt",
+          body: <<~TEXT
+            Unusable file with unknown or unsupported file type.
+            File name: #{attachment[:filename]}
+            File type: #{content_type}
+            File size: #{attachment[:body].size} bytes
+          TEXT
+        }
+      end
     end
   end
 end