Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD 502: Add EIC to pdf and XML #4939

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

MD 502: Add EIC to pdf and XML #4939

wants to merge 9 commits into from
+209 −5

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Oct 31, 2024 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Added MD 502 EIC fields

How to test?

  • Select a DF persona that has qualifying children, laney_qss is one example. And if you want to test for someone that doesn't you can use zeus_two_w2s
  • make them MFJ
  • see if EarnedIncomeCredit and MDEICWithQualChildInd are in the XML
  • see in line 22 and 22b are in the pdf

Screenshots (for visual changes)

  • After
    Screenshot 2024-11-04 at 6 33 24 PM
    Screenshot 2024-11-04 at 6 33 33 PM

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4939-74d6237e529f.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4939 (optionally add --tail)

@embarnard embarnard marked this pull request as ready for review November 4, 2024 22:55
arinchoi03
arinchoi03 reviewed Nov 6, 2024
View reviewed changes
app/lib/efile/md/md502_calculator.rb Outdated Show resolved Hide resolved
app/lib/submission_builder/ty2024/states/md/documents/md502.rb Outdated Show resolved Hide resolved
app/models/direct_file_data.rb Outdated Show resolved Hide resolved
spec/lib/efile/md/md502_calculator_spec.rb Outdated Show resolved Hide resolved
spec/lib/efile/md/md502_calculator_spec.rb Outdated Show resolved Hide resolved
arinchoi03
arinchoi03 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@embarnard @arinchoi03