Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated references to 2023 schema to 2024 schema #4893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated references to 2023 schema to 2024 schema #4893

wants to merge 1 commit into from
+7 −8

Conversation

jachan
Copy link
Contributor

@jachan jachan commented Oct 21, 2024 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • No

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Updated schemas from 2023 to 2024

How to test?

  • Installed 2024 NJ schemas locally and ran rspec locally
  • Risk Assessment
    • Tests may fail until NJ 2024 schemas are installed on the test environment

Screenshots (for visual changes)

N/A

jachan
jachan commented Oct 21, 2024
View reviewed changes
app/services/state_file/state_information_service.rb
@@ -49,8 +50,6 @@ def state_intake_class_names
end
end

private
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubocop: https://docs.rubocop.org/rubocop/cops_lint.html#lintuselessaccessmodifier

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4893-4a69416f0b1e.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4893 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrotondo mrotondo mrotondo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jachan @mrotondo