Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facebook Integration #25

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dillondrobena
Copy link

Added facebook post integration. Similar to twitter you need to get a facebook access_token and add that as an environment variable. I added some instructions in the README. If you don't want to schedule it on heroku you can just run the rake task rake post_pet I also changed the minimum Ruby version in the Gemfile since it was conflicting for me.

@dillondrobena
Copy link
Author

Not sure why the tests failed, but everything should work correctly.

@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .idea folder is specific to your text editor (RubyMine). You should add it to your global .gitignore and remove it from this repo.

@boonrs
Copy link
Contributor

boonrs commented May 18, 2015

Great start @dillondrobena, this is something we've wanted for a while! 💥

@drewrwilson
Copy link
Contributor

😎 so cool

require 'minitest/autorun'

describe 'TweetGenerator' do
describe '.create_message' do
it 'returns a string with the pet name, description and shelter link' do
message = TweetGenerator.create_message('Moofle', 'neutered female lab', 'http://www.example.org/moofle')
message = PostGenerator.create_message('Moofle', 'neutered female lab', 'http://www.example.org/moofle')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@dillondrobena
Copy link
Author

Sorry it took so long to update again. Not sure what to do about this VCR issue. I want CI to pass but I don't want to commit the keys for pet_harbor and pet_finder

@dillondrobena
Copy link
Author

Ok fixed it, everything should be working now

@dillondrobena dillondrobena changed the title Added Facebook Integration #15 Added Facebook Integration Dec 10, 2015
@dillondrobena dillondrobena changed the title #15 Added Facebook Integration Added Facebook Integration Dec 10, 2015
@aabowen
Copy link
Contributor

aabowen commented Sep 30, 2016

So, are you planning on posting a guide for the new Facebook integration?

@dillondrobena
Copy link
Author

@aabowen I updated the README.md to provide instructions for getting Facebook to work. Although it's been a while since I've looked at this project, but I would imagine it still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants