Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to pro card added in sidebar #9

Merged
merged 1 commit into from
Feb 29, 2024
Merged

upgrade to pro card added in sidebar #9

merged 1 commit into from
Feb 29, 2024

Conversation

ct-anjali-rana
Copy link
Contributor

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@phoenixcoded20 phoenixcoded20 merged commit 9e4ae19 into stage-1.3.0 Feb 29, 2024
@phoenixcoded20 phoenixcoded20 deleted the package-updates branch February 29, 2024 05:14
phoenixcoded20 added a commit that referenced this pull request Feb 29, 2024
@ct-anjali-rana @phoenixcoded20
Stage 1.3.0 (#8)
fcd5071 
* custom class remove, footer add, eslint any error solved and all packages updates

* upgrade to pro card added in sidebar (#9)

* Update package.json

* Update VerticalSidebar.vue

---------

Co-authored-by: CodedThemes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ct-anjali-rana @phoenixcoded20