Update integration page styling and added intro summary #95
Conversation
| <form action="https://slack.com/oauth/v2/authorize" method="GET"> | ||
| <input type="hidden" name="client_id" value="{{ client_id }}"> | ||
| <input type="hidden" name="scope" value="{{ scope }}"> | ||
| <input type="hidden" name="redirect_uri" value="{{ redirect_uri }}"> | ||
| <input type="hidden" name="state" value="{{ state }}"> | ||
| <button type="submit">Install Codecov App for Slack</button> |
There was a problem hiding this comment.
Because this is a form, we should keep type="submit" https://www.w3schools.com/tags/tag_button.asp
| @@ -1,131 +1,40 @@ | |||
|
|
|||
There was a problem hiding this comment.
Do you mind running black and isort for this file to better format the file 🙏
|
It generally looks good but a couple of important things:
Otherwise, if we're not looking to complicate things and use static files, it might be worth it to serve the image in google storage and just keep using embedded style sheets :// I can take care of CSP changes if that's ok. |
We just need to update with new pics once it's deployed in google api storage! |
RulaKhaled
force-pushed
the
update-slack-install-landing
branch
from
91e7cb9
to
767e0c2
Compare
Summary
PR updates the current https://slack.codecov.io/slack/install with new styling aligned with Codecov branding, copy, and is initial iteration to following iterations (see here)
Changes
Checklist
Additional Notes