Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): update pypi packaging #604
base: main
Are you sure you want to change the base?
chore(release): update pypi packaging #604
Changes from all commits
28359f4
628be10
cd25cc3
523cb96
8ac380f
1bf1eb9
4f76ae7
4f8a082
70afd28
e0501e9
5741400
7440fc8
c21c77b
a54b07c
4e1317d
7ff9954
58adb2f
5af56d3
64b4014
0cccacf
29aefe9
c8f1ee6
18e1b6f
84b3110
ae13da2
d1de10c
eed38e0
c6db499
7cabf3f
930fd02
90ac85c
1fcbe17
6681711
a8b0785
19b0087
159cc0a
0c2f99d
63754d6
5c40814
badf918
ca1386f
4656ba8
b0706b6
4be3b24
3d16042
beb3cca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try also setting this somewhere in the cibuildwheel config to have the pins there too. This might need some experimentation, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'm not sure that will be as easily possible if there is no checkout-like step for building the dist wheels. any advice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasrockhu-codecov the trick is to include all the source files into sdist. When not using
setuptools-scm
that does this automatically, you'll have to add them intoMANIFEST.in
manually. sdist is your checkout in this context.Ideally, sdist contents should be as close to Git checkout as possible. Many downstreams use sdists as the source of truth, meaning that they don't just build wheels from sdist, but also run the tests and build the docs out of it. Well, if said sdist is well maintained and doesn't rip them out forcing working with Git, that is.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the Python version in this job is 3.11+, you can just use the stdlib module for reading TOML:
(if not — call
actions/setup-python
earlier to ensure it's modern enough)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note that I'm setting
release-version
overrelease_version
, and a new step ID here because it's usually helpful to have kebab-case identifiers in GHA, making it easier to distinguish them from identifiers from other embedded scripts)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the future: include the entire repo. Well, except GHA automation and some helper scripts that aren't needed for running tests/building docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh, is that the preferred way of doing this?