Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render for filter register by venue #64

Merged

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented May 27, 2024

Related to changes in this PR of the codecheck package: codecheckers/codecheck#40

  • Reran render_register with the new feature of filter registers by venue.
  • Deleted html_document.yml file as it is dynamically generated.
  • Added html_document.yml to .gitignore file

@angelina-momin angelina-momin requested a review from nuest May 27, 2024 16:23
@angelina-momin angelina-momin changed the title Rerun render_register for new feature of sort register by venue Render for filter register by venue Jun 18, 2024
@nuest
Copy link
Member

nuest commented Jun 18, 2024

I would really like to have only one libs folder - can we fix that path in the rendering?

@angelina-momin
Copy link
Collaborator Author

angelina-momin commented Jun 19, 2024

@nuest Good point thanks! I just fixed it.

I found two possible solutions:

  1. set a shared "libs" folder during the rendering (I tried this and it does not work).
    rmarkdown::render( input = temp_md_file_path, output_file = "index.html", output_dir = output_dir, output_yaml = yaml_path, output_options = list(self_contained=FALSE, lib_dir= relative_libs_dir) )

This is a known issue in Rmarkdown package apparently and it has not been fixed yet: rstudio/rmarkdown#146, rstudio/rmarkdown#1859 and PR rstudio/rmarkdown#2199.

  1. Write a function that alters the paths to the libs folder for each html file created. This is not the cleanest solution but it does mean we will not have multiple "libs" folder and hence save space.

I decided to stick to this solution for now until the issue related to the former solution is fixed in the rmarkdown package.

@angelina-momin angelina-momin merged commit 9c8a7bd into master Jun 19, 2024
@angelina-momin angelina-momin deleted the Render-for-new-feature-to-sort-registry-by-venue branch June 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants