Fix invalid parameter definitions when methods have nonzero enum default values #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmckenzie
force-pushed
the
fix/handle-enum-default-values
branch
from
3c06186 to
9f6c968
Compare
…ult values This addresses a bug where there's no cast when generating a definition for a parameter with a nonzero default enum parameter value. Previously, it would generate values like this: ```csharp void MethodWithDefaultParameter(MyEnum value = 1); ``` This would not compile, as there's no implicit conversion from nonzero integral types to enum values. - Reinstated the default value generation logic that was removed in codecentric#65, as default values generated by Roslyn aren't guaranteed to be valid code, and, in the case of enum default values, clearly aren't. - Added special case when generating default values for enum parameters (cast nonzero values to the enum type) - Added tests, and moved all parameter tests into the `.MethodParameters.cs` test file
simonmckenzie
force-pushed
the
fix/handle-enum-default-values
branch
from
9f6c968 to
e125699
Compare
simonmckenzie
commented
Jan 27, 2025
Comment on lines
+138
to
+146
| string value => $"\"{value}\"", | ||
| bool value => $"{(value ? "true" : "false")}", | ||
| object value when IsEnum(parameterSymbol.Type, out var enumType) && !Equals(value, 0) | ||
| => $"({enumType!.ToDisplayString(FullyQualifiedDisplayFormat)}){value}", | ||
| // struct | ||
| null when parameterSymbol.Type.IsValueType | ||
| => $"default({parameterSymbol.Type.ToDisplayString(FullyQualifiedDisplayFormat)})", | ||
| null => "null", | ||
| _ => $"{parameterSymbol.ExplicitDefaultValue}", |
There was a problem hiding this comment.
This code, apart from the enum-specific branch, has been restored as-is from the version of the class prior to the last PR.
simonmckenzie
changed the title
|
Superseded by #70. It solves the problem much more simply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where there's no cast when generating a definition for a parameter with a nonzero default enum parameter value. Previously, it would generate values like this:
This would not compile, as there's no implicit conversion from nonzero integral types to enum values. The only implicit enum conversion is from zero (§10.2.4), which the new code does handle.
This was reported in issue #67.
Changes
.MethodParameters.cstest file