Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fullscreen key #1759

Closed
wants to merge 2 commits into from
Closed

Fix fullscreen key #1759

wants to merge 2 commits into from

Conversation

0x4nud33p
Copy link

PR Fixes:

  • 1 Fixed Invalid target for null#one; must be a DOM node or evented object error when attempting fullscreen.
  • 2 Ensured requestFullscreen() is called on the correct DOM element (player.el()).

Resolves #1754

Checklist before requesting a review

  • [✅ ] I have performed a self-review of my code
  • [ ✅] I assure there is no similar/duplicate pull request regarding same issue

@0x4nud33p 0x4nud33p closed this Feb 19, 2025
@0x4nud33p 0x4nud33p deleted the fix-fullscreen-key branch February 19, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: want a shortcut for fullscreen
1 participant
@0x4nud33p