Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor links to accept another origin #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor links to accept another origin #1

wants to merge 5 commits into from

Conversation

AbdBarho
Copy link
Member

@AbdBarho AbdBarho commented May 15, 2019

this refactor includes major changes:

  • created a new WDQS (WikiData Query Service) class, which basically takes all the calls and redirects them to an instance of the query service (which can be defined as a parameter)
  • refactored all python function calls to use the newly added WDQS instead of the hard coded links
  • injected a variable in the Flask enivornment which is {{ queryServiceUrl }} which gets replaced by the url to the query service defined in WDQS
  • refactored all template pages to use the newly created variable
  • a LOT of whitespace has been removed

maybe it would be better to merge this pull request to its own branch instead of the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant