Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localhost.hourofcode.com to webpack.config.js #58785

Merged
merged 1 commit into from
May 21, 2024
Merged

Add localhost.hourofcode.com to webpack.config.js #58785

merged 1 commit into from
May 21, 2024

Conversation

kelbyhawn
Copy link
Contributor

@kelbyhawn kelbyhawn commented May 20, 2024 •
edited

Adds localhost.hourofcode.com to the webpack.config.js file to reduce Invalid Host/Origin header console errors.

Seth and Ben: adding y'all for visibility, and thanks @hannahbergam for helping with this!

Links

Jira ticket: ACQ-1910
Slack convo inspiration: here

Testing story

Tested locally to make sure console errors are gone

Before After
Before After

@kelbyhawn kelbyhawn requested review from a team, snickell and bencodeorg May 20, 2024 20:50
hannahbergam
hannahbergam approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thanks for making this PR! This worked for me locally.

bencodeorg
bencodeorg approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for doing this!

@kelbyhawn kelbyhawn merged commit a8bb2ac into staging May 21, 2024
2 checks passed
@kelbyhawn kelbyhawn deleted the add-hoc-site-to-webpack-config branch May 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodeorg bencodeorg bencodeorg approved these changes

@hannahbergam hannahbergam hannahbergam approved these changes

@snickell snickell Awaiting requested review from snickell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelbyhawn @bencodeorg @hannahbergam