Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public gallery has been updated banner #58782

Merged
merged 1 commit into from
May 21, 2024
Merged

Remove public gallery has been updated banner #58782

merged 1 commit into from
May 21, 2024

Conversation

fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented May 20, 2024 •
edited

This PR removes the banner on '/projects' for signed-in users that announced that the public gallery has been updated. It reverts the changes included in #57473.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice marked this pull request as ready for review May 20, 2024 19:56
@fisher-alice fisher-alice requested a review from a team as a code owner May 20, 2024 19:56
@fisher-alice fisher-alice requested a review from a team May 20, 2024 19:56
bencodeorg
bencodeorg approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

cnbrenci
cnbrenci approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@cnbrenci cnbrenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping track of this & cleaning it up!!

@fisher-alice fisher-alice merged commit d95ab58 into staging May 21, 2024
2 checks passed
@fisher-alice fisher-alice deleted the alice/remove-featured-projects-banner branch May 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnbrenci cnbrenci cnbrenci approved these changes

@bencodeorg bencodeorg bencodeorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisher-alice @cnbrenci @bencodeorg