Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear chat history when switching user views of aichat level #58774

Merged
merged 2 commits into from
May 21, 2024

Conversation

fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented May 20, 2024

This PR updates aichat so that when a teacher switches the user view of an aichat level via the teacher channel, the chat history is cleared.

After update

clear-chat.mp4

Links

jira

Testing story

Tested locally in /allthethings aichat levels with a teacher account with a section that has two student accounts.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice marked this pull request as ready for review May 20, 2024 16:53
@fisher-alice fisher-alice requested a review from a team May 20, 2024 16:53
@bencodeorg
Copy link
Contributor

I don't even know if I agree with my past self here, but thoughts on keeping the clearing logic together with what we have in AichatView?

#58103 (comment)

@fisher-alice
Copy link
Contributor Author

I don't even know if I agree with my past self here, but thoughts on keeping the clearing logic together with what we have in AichatView?

#58103 (comment)

Oh yeah - I think it would make sense to move to AichatView. Thanks!

Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@fisher-alice fisher-alice merged commit 47ec92e into staging May 21, 2024
2 checks passed
@fisher-alice fisher-alice deleted the alice/clear-chat branch May 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants