Don't throw a honeybadger error on importing a blank csv #58761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want this to be a supported path, actually? I can't imagine someone would do this on purpose, and since it's a destructive operation on the existing table content, it feels like we should throw up a modal and block the action instead? |
|
I went back and forth on this, but landed here. I take it this means you disagree? I'm working on implementing the other approach, should have something in a sec. |
|
Now we raise this dialog on the PR, whatcha think? |
cnbrenci
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58754, which came from a honeybadger error
Was able to repro the honeybadger error by importing a blank CSV. After this PR, its succeeds silently.
records.insert_all(), invoked by create_records which is invoked by import_csv throwsArgumentError: Empty list of attributes passedif called with an empty list of record_json. This means importing a blank .csv file silently raises an error, when its really a reasonable thing to import (blank table). We detect this condition and successfully insert nothing.