Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update csf and csd language list on curriculum marketing pages #58727

Merged
merged 3 commits into from
May 21, 2024
Merged

Update csf and csd language list on curriculum marketing pages #58727

merged 3 commits into from
May 21, 2024

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented May 17, 2024 •
edited

How I built this string:

  • I copy pasted the local language name from the cdo-languages gsheet for each language in the translateable string
  • I checked with Jorge and made a couple of small adjustments
    • Jorge told me that English is not needed in these strings

CSF:
Screenshot 2024-05-17 at 3 48 01 PM

CSD:
Screenshot 2024-05-17 at 3 27 20 PM

@bethanyaconnor bethanyaconnor changed the title Bethany/marketing/update csf and csd language list Update csf and csd language list on curriculum marketing pages May 20, 2024
@bethanyaconnor bethanyaconnor marked this pull request as ready for review May 20, 2024 12:22
@bethanyaconnor bethanyaconnor requested a review from a team as a code owner May 20, 2024 12:22
@bethanyaconnor bethanyaconnor requested a review from a team May 20, 2024 12:22
kelbyhawn
kelbyhawn approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bethanyaconnor bethanyaconnor merged commit 5010e38 into staging May 21, 2024
2 checks passed
@bethanyaconnor bethanyaconnor deleted the bethany/marketing/update-csf-and-csd-language-list branch May 21, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelbyhawn kelbyhawn kelbyhawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bethanyaconnor @kelbyhawn