Skip to content

Track project events #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begedin merged 8 commits into from
Feb 14, 2018
Merged

Track project events #1364

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f6c18a
Add function to extract project id from resources
iref Jan 4, 2018
24ffd7c
Add event tracking for projects to segment plug
iref Jan 8, 2018
d37bbe9
Add event direction to tracking event names
iref Jan 11, 2018
aa13ed8
Move get_project_id to preserve alphabetic ordering.
iref Jan 12, 2018
cc2f8c8
Add acceptor to project user events
iref Jan 12, 2018
43268dc
Rename current_user in update event to acceptor
iref Jan 12, 2018
e42e9ae
Removed unnecessary project_id? function
iref Jan 12, 2018
3257fa7
Remove unnecessary id param in event name builder
iref Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/code_corps/analytics/segment_data_extractor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,12 @@ defmodule CodeCorps.Analytics.SegmentDataExtractor do
def get_user_id(%Plug.Conn{assigns: %{current_user: %CodeCorps.User{id: id}}}, _), do: id
def get_user_id(_, %CodeCorps.User{id: id}), do: id
def get_user_id(_, %{user_id: user_id}), do: user_id

@doc """
Tries to extract project id from given resource.
Returns `nil` if project id can't be extracted.
"""
@spec get_project_id(CodeCorps.ProjectUser.t) :: String.t | nil
def get_project_id(%CodeCorps.ProjectUser{project_id: id}), do: "project_#{id}"
def get_project_id(_), do: nil
Copy link
Contributor

@joshsmith joshsmith Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this up above get_resource just to keep things alpha-ordered. We try to generally alpha-order things for quick scannability.

Copy link
Contributor

@begedin begedin Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolved, but github did not mark it outdated.

end
6 changes: 6 additions & 0 deletions lib/code_corps/analytics/segment_plug_tracker.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ defmodule CodeCorps.Analytics.SegmentPlugTracker do
if successful? && SegmentTrackingSupport.includes?(action, resource) do
user_id = SegmentDataExtractor.get_user_id(conn, resource)
SegmentTracker.track(user_id, action, resource)

project_id = SegmentDataExtractor.get_project_id(resource)
if project_id do
SegmentTracker.track(project_id, action, resource)
end

mark_tracked(conn)
else
mark_untracked(conn)
Expand Down
23 changes: 23 additions & 0 deletions test/lib/code_corps/analytics/segment_data_extractor_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
defmodule CodeCorps.Analytics.SegmentDataExtractorTest do
@moduledoc false

use ExUnit.Case, async: true

import CodeCorps.Factories

alias CodeCorps.Analytics.SegmentDataExtractor

describe "get_project_id/1" do
test "should return correct id for project user" do
project_user = build(:project_user)
project_id = "project_#{project_user.project_id}"

assert SegmentDataExtractor.get_project_id(project_user) == project_id
end

test "should return nil for unknown resource" do
assert SegmentDataExtractor.get_project_id(%{}) == nil
end
end

end
4 changes: 4 additions & 0 deletions test/lib/code_corps_web/controllers/project_user_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
assert conn |> request_create(attrs) |> json_response(201)

user_id = user.id
project_id = "project_#{project.id}"

tracking_properties = %{
project: project.title,
Expand All @@ -58,6 +59,7 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
}

assert_received {:track, ^user_id, "Requested Project Membership", ^tracking_properties}
assert_received {:track, ^project_id, "Requested Project Membership", ^tracking_properties}

email =
CodeCorps.ProjectUser
Expand Down Expand Up @@ -106,6 +108,7 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
assert json["data"]["attributes"]["role"] == "contributor"

user_id = current_user.id
project_id = "project_#{project.id}"

tracking_properties = %{
project: project.title,
Expand All @@ -115,6 +118,7 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do
}

assert_received {:track, ^user_id, "Approved Project Membership", ^tracking_properties}
assert_received {:track, ^project_id, "Approved Project Membership", ^tracking_properties}

email =
CodeCorps.ProjectUser
Expand Down