Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove spurious "v" from version number #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prcr
Copy link

@prcr prcr commented Dec 28, 2022

I noticed that the latest ShellCheck bump includes a spurious "v" at the start of the version number while generating the release notes. Besides breaking the automatic generation of a link to the changelog of the new tool version:

  • This seems to be a bug because the script doc-generator/generate.sh will then fail to checkout the correct tag from the ShellCheck Git repository
  • All other tools use the <Major>.<minor>.<patch> version syntax or similar, without including the "v" prefix

Copy link

@stefanvacareanu7 stefanvacareanu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that I modified this last time in order to make the script work. I believe just reverting it may break something else. I added this on my to-do to check it soon and see how to make it work

prcr pushed a commit to codacy/docs that referenced this pull request Feb 1, 2023
nicklem added a commit to codacy/docs that referenced this pull request Feb 3, 2023
* feat: Release notes for Codacy Cloud January 2023

* feat: Add new release  notes page to mkdocs.yml and index.md

* feat: Do initial review of product enhancements

* feat: Do initial review of bug fixes

* clean: Clean up list of issues to check manually

* fix: Update broken link

* clean: Review release note for IO-359

* clean: Review release notes for IO-152 and COV-2

* clean: Clean up ShellCheck version number

See codacy/codacy-shellcheck#35

* feat: Add changelog links for SpotBugs and SwiftLint

* clean: Tweak release note for PLUTO-290

* style: Apply code style to permission scope

* feat: Add end-to-end API endpoint example to identify commits without coverage data

* feat: Wording for clarity

Co-authored-by: Cláudia Carpinteiro <[email protected]>

---------

Co-authored-by: Cláudia Carpinteiro <[email protected]>
Co-authored-by: nicklem <[email protected]>
Co-authored-by: Cláudia Carpinteiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants