Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix docs TS-672 #4170

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Feature/fix docs TS-672 #4170

merged 4 commits into from
Nov 24, 2023

Conversation

codacy-vrhpires
Copy link
Contributor

@codacy-vrhpires codacy-vrhpires commented Nov 24, 2023 •
edited
Loading

  • updated README instructions
  • [breaking] changed category to type - ESLint stopped using category - so patterns documentation is now correctly processed:
    • reviewed documentation generator code
    • updated tests

@codacy-vrhpires codacy-vrhpires marked this pull request as ready for review November 24, 2023 12:51
stefanvacareanu7
stefanvacareanu7 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@stefanvacareanu7 stefanvacareanu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codacy-vrhpires codacy-vrhpires merged commit e24df7e into master Nov 24, 2023
2 checks passed
@codacy-vrhpires codacy-vrhpires deleted the feature/fix-docs_TS-672 branch November 24, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanvacareanu7 stefanvacareanu7 stefanvacareanu7 approved these changes

@DMarinhoCodacy DMarinhoCodacy Awaiting requested review from DMarinhoCodacy

@lolgab lolgab Awaiting requested review from lolgab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codacy-vrhpires @stefanvacareanu7