raft: support lazy replication #131588
Merged
raft: support lazy replication #131588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pav-kv
force-pushed
the
raft-lazy-replication
branch
2 times, most recently
from
13b9369
to
1bd9d89
Compare
pav-kv
force-pushed
the
raft-lazy-replication
branch
from
1bd9d89
to
f0df3d7
Compare
tbg
reviewed
Oct 1, 2024
This commits adds a prep test for the next commit, to demonstrate the difference between the eager and lazy replication. Epic: none Release note: none
Epic: none Release note: none
This commit adds support for LazyReplication mode in raft. In this mode, the leader does not send MsgApp messages eagerly to StateReplicate peers. Instead, the appends are requested explicitly by the application layer, via the RawNode.SendMsgApp() method. The application: - monitors the replication flow state to all followers, e.g. using the RawNode.Status() method, - for peers who have outstanding replication work, decides when and how much worth of the log to send out, - fetches the log slice from the RawNode.LogSnapshot(), - sends the appends using the RawNode.SendMsgApp() method. Epic: none Release note: none
Epic: none Release note: none
pav-kv
force-pushed
the
raft-lazy-replication
branch
from
f0df3d7
to
476b4f0
Compare
sumeerbhola
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Reviewed 1 of 7 files at r5, 2 of 2 files at r6, 2 of 2 files at r7, 4 of 5 files at r8, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh and @tbg)
|
bors r=tbg,sumeerbhola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
LazyReplicationmode in raft. In this mode, the leader does not sendMsgAppmessages eagerly toStateReplicatepeers. Instead, the appends are requested explicitly by the application layer, via theRawNode.SendMsgApp()method.The application:
RawNode.Status()method,RawNode.LogSnapshot(),RawNode.SendMsgApp()method.Part of #128779