Skip to content

Commit

Permalink
Merge #125937
Browse files Browse the repository at this point in the history
125937: sqlstats: revert turning off sql activity tables r=xinhaoz a=xinhaoz

This commit reverts PR #123381 which turned off the sql activity update job by default. We'll punt disabling this flush job to the next major release. The justification for this is we changed some cluster settings for sql stats for 24.1.2 that will cap the number of rows per aggregation interval. We'll wait for existing clusters to stabilize with this cap before disabling the cache entirely.

Epic: none
Part of: #123081

Release note: None

Co-authored-by: Xin Hao Zhang <[email protected]>
  • Loading branch information
craig[bot] and xinhaoz committed Jun 20, 2024
2 parents e14171e + 60ed997 commit 564d0ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/sql/sql_activity_update_job.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var sqlStatsActivityFlushEnabled = settings.RegisterBoolSetting(
settings.ApplicationLevel,
"sql.stats.activity.flush.enabled",
"enable the flush to the system statement and transaction activity tables",
false)
true)

// sqlStatsActivityTopCount is the cluster setting that controls the number of
// rows selected to be inserted into the activity tables
Expand Down

0 comments on commit 564d0ec

Please sign in to comment.