Docker_image.rst: remove pip install instruction #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
ack f37de42 |
|
@gitmate-bot rebase |
This commit makes sure that the `pip install -r requirements.txt` will no longer appear in Docker_image.rst. It is not necessary with a docker image. Closes coala#486
|
Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost! |
|
Automated rebase was successful! |
|
unack |
gitmate-bot
added
process/approved
and removed
process/pending review
process/approved
labels
|
Please rewrite commit message. "This commit makes sure that the ..." is too wordy - that could be the first words of every commit message, but it is not ... it would be redundant to start every commit message like that. Describe briefly what is in the commit, and why. |
|
unack 40329da |
|
(and rebase your commit) |
|
@jayvdb I have updated my comment. How do I do rebase? |
http://docs.coala.io/en/latest/Users/Docker_Image.html#coala-on-gitlab-ci mentions invokingpip install -r requirements.txt. It is unnecessary and the documentation has been updated to show the changes. Closes coala#486
|
three commits instead of one. |
|
Why closed this PR? Btw this happened with me also :P |
|
Yes, I will do it
…On Nov 9, 2017 13:33, "GitMate" ***@***.***> wrote:
Assigned #489 <#489> to
@vipuldcoder <https://github.com/vipuldcoder>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#489 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AV-mXDGga6TiuJruJuwpDppHFUpRZDYeks5s0rHLgaJpZM4QSHjA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker_image.rst: remove pip install instruction
http://docs.coala.io/en/latest/Users/Docker_Image.html#coala-on-gitlab-ci mentions invoking
pip install -r requirements.txt. It is unnecessary and the documentation has been updated to show the changes.Closes #486