Rather set namespace in cnf-testsuite.yml if helm_dirs

It also uses the right constant instead of cnf-testsuite directly
and unifies all samples to use namespace cnfspace.

It also fixes a spec test in shared_database, installing now
the chart in a dedicated namespace with the right labels.

Signed-off-by: Cédric Ollivier <[email protected]>

sample-cnfs/k8s-multiple-processes/chart/templates/pod.yml

@@ -1,17 +1,7 @@
----
-apiVersion: v1
-kind: Namespace
-metadata:
-  name: cnfspace
-  labels:
-    pod-security.kubernetes.io/enforce: privileged
-
----
 apiVersion: v1
 kind: Pod
 metadata:
   name: sidecar-container-demo
-  namespace: cnfspace
 spec:
   containers:
   - image: busybox
@@ -33,4 +23,4 @@ spec:
   dnsPolicy: Default
   volumes:
   - name: var-logs
-    emptyDir: {}
+    emptyDir: {}

sample-cnfs/k8s-multiple-processes/cnf-testsuite.yml

@@ -4,3 +4,4 @@ deployments:
   helm_dirs:
   - name: sidecar-container-demo
     helm_directory: chart
+    namespace: cnfspace

sample-cnfs/k8s-sidecar-container-pattern/chart/templates/pod.yml

@@ -1,17 +1,7 @@
----
-apiVersion: v1
-kind: Namespace
-metadata:
-  name: cnfspace
-  labels:
-    pod-security.kubernetes.io/enforce: privileged
-
----
 apiVersion: v1
 kind: Pod
 metadata:
   name: sidecar-container-demo
-  namespace: cnfspace
 spec:
   containers:
   - image: busybox
@@ -33,4 +23,4 @@ spec:
   dnsPolicy: Default
   volumes:
   - name: var-logs
-    emptyDir: {}
+    emptyDir: {}

sample-cnfs/k8s-sidecar-container-pattern/cnf-testsuite.yml

@@ -4,3 +4,4 @@ deployments:
   helm_dirs:
   - name: sidecar-container-demo
     helm_directory: chart
+    namespace: cnfspace

sample-cnfs/sample-multi-db-connections-exempt/cnf-testsuite.yml

@@ -5,3 +5,4 @@ deployments:
   - name: test
     helm_directory: wordpress
     helm_values: --set mariadb.primary.persistence.enabled=false --set persistence.enabled=false
+    namespace: cnfspace

sample-cnfs/sample-statefulset-cnf/cnf-testsuite.yml

@@ -21,3 +21,4 @@ deployments:
     helm_values: --version 15.2.0 --set mariadb.primary.persistence.enabled=false --set persistence.enabled=false
     helm_repo_name: bitnami
     helm_repo_url: https://charts.bitnami.com/bitnami
+    namespace: cnfspace

sample-cnfs/sample_coredns/cnf-testsuite.yml

@@ -4,3 +4,4 @@ deployments:
   helm_dirs:
   - name: coredns
     helm_directory: chart
+    namespace: cnfspace

spec/workload/microservice_spec.cr

@@ -68,9 +68,11 @@ describe "Microservice" do
   it "'shared_database' should pass if two services on the cluster connect to the same database but they are not in the helm chart of the cnf", tags: ["shared_database"]  do
     begin
       ShellCmd.cnf_install("cnf-path=sample-cnfs/sample_coredns")
-      Helm.install("multi-db sample-cnfs/ndn-multi-db-connections-fail/wordpress/")
-      KubectlClient::Get.resource_wait_for_install(kind: "Deployment", resource_name: "multi-db-wordpress", wait_count: 180, namespace: "default")
-      KubectlClient::Get.resource_wait_for_install(kind: "Deployment", resource_name: "multi-db-wordpress2", wait_count: 180, namespace: "default")
+      KubectlClient::Create.namespace(DEFAULT_CNF_NAMESPACE)
+      ShellCmd.run("kubectl label namespace #{DEFAULT_CNF_NAMESPACE} pod-security.kubernetes.io/enforce=privileged", "Label.namespace")
+      Helm.install("-n #{DEFAULT_CNF_NAMESPACE} multi-db sample-cnfs/ndn-multi-db-connections-fail/wordpress/")
+      KubectlClient::Get.resource_wait_for_install(kind: "Deployment", resource_name: "multi-db-wordpress", wait_count: 180, namespace: DEFAULT_CNF_NAMESPACE)
+      KubectlClient::Get.resource_wait_for_install(kind: "Deployment", resource_name: "multi-db-wordpress2", wait_count: 180, namespace: DEFAULT_CNF_NAMESPACE)
       # todo kubctl appy of all resourcesin ndn-multi-db-connections-fail
       # todo cnf_install of coredns
       # todo run shared_database (should pass)
@@ -80,7 +82,7 @@ describe "Microservice" do
       result[:status].success?.should be_true
       (/(PASSED).*(No shared database found)/ =~ result[:output]).should_not be_nil
     ensure
-      Helm.delete("multi-db")
+      Helm.delete("multi-db -n #{DEFAULT_CNF_NAMESPACE}")
       KubectlClient::Delete.command("pvc data-multi-db-mariadb-0")
       result = ShellCmd.cnf_uninstall()
       result[:status].success?.should be_true