Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

fix(modbus): failed to read e2e data from simulator #132

Merged
merged 1 commit into from
Aug 1, 2020
Merged

fix(modbus): failed to read e2e data from simulator #132

merged 1 commit into from
Aug 1, 2020

Conversation

thxCode
Copy link

@thxCode thxCode commented Jul 30, 2020

Fixes:

#131

Problem:

Modbus E2E cases have used a wrong register address.

Solution:

Adjust the E2E case YAML.

Test plan:

  • Create a local K3d cluster with cluster-k3d-spinup.sh
  • Deploy the corresponding deploy/e2e/simulator.yaml of the Modbus adaptor.
  • Deploy the corresponding deploy/e2e/dl_*.yaml of the Modbus adaptor.
  • The temperature register should not get a negative number.

@thxCode thxCode mentioned this pull request Jul 30, 2020
Open
@thxCode thxCode requested a review from guangbochen July 30, 2020 08:54
@thxCode thxCode added the area/octopus-simulator This is related to Octopus simulator label Jul 30, 2020
guangbochen
guangbochen approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guangbochen guangbochen merged commit c76abff into cnrancher:master Aug 1, 2020
@thxCode thxCode deleted the fix_modbus branch September 25, 2020 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guangbochen guangbochen guangbochen approved these changes

Assignees
No one assigned
Labels
area/octopus-simulator This is related to Octopus simulator
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thxCode @guangbochen